On Wed, May 19, 2010 at 05:45:16PM +0400, Sergei Shtylyov wrote: > Hello. > > Greg Kroah-Hartman wrote: > > Aha! Here's the offending patch... > > >From: Tony Lindgren <tony@xxxxxxxxxxx> > > >CONFIG_ARCH_OMAP34XX is now CONFIG_ARCH_OMAP3. > > >But since drivers/usb/musb/omap2430.c use CONFIG_PM for these > >registers and functions, do the same for the header. > > The original code had OMAP #ifdef for a good reason. You broke > linking for the other MUSB platforms (DaVinci, Blackfin) when > CONFIG_PM=y with this change! > > >Otherwise we get the following for most omap3 defconfigs: > > >drivers/usb/musb/omap2430.c:261: error: expected identifier or '(' before 'do' > >drivers/usb/musb/omap2430.c:261: error: expected identifier or '(' before 'while' > >drivers/usb/musb/omap2430.c:268: error: expected identifier or '(' before 'do' > >drivers/usb/musb/omap2430.c:268: error: expected identifier or '(' before 'while' > > >Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> > >Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx> > >Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx> > > I wonder how this stupid patch got accepted... You are _this_ close to being added to my kill filter... -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html