Hi Andiry and Dong, This patch causes an oops when CONFIG_PCI_MSI=n. My system hung when I attempted to plug in a USB mouse (which was the first thing that would have generated an interrupt). With the patch reverted and the kernel rebuilt with CONFIG_PCI_MSI=n, the xHCI driver works fine. Please see the attached dmesg and fix. First oops message: [ 409.092464] BUG: unable to handle kernel NULL pointer dereference at 000000000000028b [ 409.092611] IP: [<ffffffff81081538>] __lock_acquire+0x2c8/0x560 [ 409.092716] PGD 0 [ 409.092807] Oops: 0000 [#1] SMP [ 409.092947] last sysfs file: /sys/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1/stat [ 409.092999] CPU 0 [ 409.093050] Modules linked in: xhci_hcd netconsole configfs binfmt_misc fbcon tileblit font bitblit softcursor ppdev lp parport snd_hda_codec_conexant snd_hda_intel snd_hda_codec snd_pcm_oss snd_mixer_oss snd_pcm thinkpad_acpi snd_seq_dummy snd_seq_oss arc4 snd_seq_midi snd_rawmidi snd_seq_midi_event snd_seq iwlagn iwlcore i915 snd_timer snd_seq_device drm_kms_helper mac80211 psmouse drm snd pcspkr serio_raw i2c_algo_bit led_class tpm_tis iTCO_wdt iTCO_vendor_support cfg80211 soundcore video nvram tpm tpm_bios joydev snd_page_alloc output intel_agp hid_logitech ff_memless usbhid ehci_hcd uhci_hcd usbcore [ 409.096165] [ 409.096220] Pid: 0, comm: swapper Not tainted 2.6.34-rc7 #474 74663HU/74663HU [ 409.096272] RIP: 0010:[<ffffffff81081538>] [<ffffffff81081538>] __lock_acquire+0x2c8/0x560 [ 409.096375] RSP: 0018:ffff880002603d58 EFLAGS: 00010046 [ 409.096426] RAX: 0000000000000046 RBX: 0000000000000283 RCX: 0000000000000000 [ 409.096443] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000283 [ 409.096443] RBP: ffff880002603da8 R08: 0000000000000000 R09: 0000000000000001 [ 409.096443] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 [ 409.096443] R13: ffffffff81ae1020 R14: 0000000000000001 R15: 0000000000000283 [ 409.096443] FS: 0000000000000000(0000) GS:ffff880002600000(0000) knlGS:0000000000000000 [ 409.096443] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b [ 409.096443] CR2: 000000000000028b CR3: 0000000001ad9000 CR4: 00000000000406b0 [ 409.096443] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 409.096443] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 [ 409.096443] Process swapper (pid: 0, threadinfo ffffffff81a00000, task ffffffff81ae1020) [ 409.096443] Stack: [ 409.096443] ffff880100000000 ffff880002603d80 ffffffff8153c2f6 0000000000000000 [ 409.096443] <0> ffff88013bc04428 0000000000000001 0000000000000000 0000000000000000 [ 409.096443] <0> 0000000000000000 0000000000000283 ffff880002603e28 ffffffff81081870 [ 409.096443] Call Trace: [ 409.096443] <IRQ> [ 409.096443] [<ffffffff8153c2f6>] ? _raw_spin_unlock+0x26/0x30 [ 409.096443] [<ffffffff81081870>] lock_acquire+0xa0/0x140 [ 409.096443] [<ffffffffa03053a9>] ? xhci_irq+0x39/0x330 [xhci_hcd] [ 409.096443] [<ffffffff8153c2f6>] ? _raw_spin_unlock+0x26/0x30 [ 409.096443] [<ffffffff8153bc9c>] _raw_spin_lock+0x2c/0x40 [ 409.096443] [<ffffffffa03053a9>] ? xhci_irq+0x39/0x330 [xhci_hcd] [ 409.096443] [<ffffffffa03053a9>] xhci_irq+0x39/0x330 [xhci_hcd] [ 409.096443] [<ffffffff810b1ef8>] handle_IRQ_event+0x48/0x150 [ 409.096443] [<ffffffff810b441d>] handle_fasteoi_irq+0x7d/0x100 [ 409.096443] [<ffffffff8100c8ed>] handle_irq+0x1d/0x30 [ 409.096443] [<ffffffff8100bfe7>] do_IRQ+0x67/0xf0 [ 409.096443] [<ffffffff8153c613>] ret_from_intr+0x0/0x11 [ 409.096443] <EOI> [ 409.096443] [<ffffffff812d8ca9>] ? acpi_idle_enter_bm+0x284/0x2b8 [ 409.096443] [<ffffffff812d8ca2>] ? acpi_idle_enter_bm+0x27d/0x2b8 [ 409.096443] [<ffffffff8141001f>] cpuidle_idle_call+0x9f/0x130 [ 409.096443] [<ffffffff81008993>] cpu_idle+0x63/0xc0 [ 409.096443] [<ffffffff81524929>] rest_init+0xb9/0xd0 [ 409.096443] [<ffffffff81524870>] ? rest_init+0x0/0xd0 [ 409.096443] [<ffffffff81b89ddc>] start_kernel+0x3c1/0x3cd [ 409.096443] [<ffffffff81b89341>] x86_64_start_reservations+0x12c/0x130 [ 409.096443] [<ffffffff81b8943f>] x86_64_start_kernel+0xfa/0x109 [ 409.096443] Code: c0 01 83 f8 2f 41 89 85 e0 06 00 00 0f 87 9c 01 00 00 3b 05 5f 10 c2 00 0f 87 20 01 00 00 b8 01 00 00 00 e9 71 fe ff ff 0f 1f 00 <48> 8b 53 08 48 85 d2 0f 85 bb fd ff ff e9 86 fd ff ff 66 0f 1f [ 409.096443] RIP [<ffffffff81081538>] __lock_acquire+0x2c8/0x560 [ 409.096443] RSP <ffff880002603d58> [ 409.096443] CR2: 000000000000028b [ 409.096443] ---[ end trace f2c58c8bb13687b6 ]--- Looks like the xhci_hcd pointer is NULL? Sarah Sharp
Attachment:
amd-msi.tar.gz
Description: Binary data
