On Sun, 16 May 2010, Felipe Contreras wrote: > Use pr_foo and dev_foo instead of printk. Maybe US_DEBUG* should be > replaced too. Absolutely US_DEBUG* should be replaced. It has been obsolete for I don't know how long. At least 5 years, probably more. In general I have no objection to these patches. But some of the changes do look a little peculiar. For example: > - printk(KERN_WARNING USB_STORAGE > - "Unable to allocate the scsi host\n"); > + dev_warn(&intf->dev, > + "Unable to allocate the scsi host\n"); Why is the new statement split into two lines? Doesn't it all fit in one line? The same sort of thing occurs in several places. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
