Re: [PATCH] checkstack fix for isd200.c: isd200_srb_set_bufflen()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 05/14/2010 03:08 PM, Greg KH wrote:
On Wed, May 12, 2010 at 06:40:21PM -0400, Prarit Bhargava wrote:
When doing a checkstack compile the following error is seen

drivers/usb/storage/isd200.c: In function 'isd200_action':
drivers/usb/storage/isd200.c:580: warning: the frame size of 2192 bytes is larger than 2048 bytes

This is because a scsi_device struct is allocated on the stack.  This patch
makes the allocation dynamic.

Signed-off-by: Prarit Bhargava<prarit@xxxxxxxxxx>

diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c
This patch doesn't apply, what kernel version did you make it against?

Latest linux-2.6.git ...  I just tried it again and it applies there.

[prarit@prarit linux-2.6]$ patch -p1 < /tmp/saved-usb-checkstack.patch
(Stripping trailing CRs from patch.)
[prarit@prarit linux-2.6]$

Care to redo it against linux-next and resend it to me?

Sure, np.

P.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux