> On Wed, May 12, 2010 at 12:51:13PM +0200, Michal Nazarewicz wrote: >> In to places in fsg_common_init() an unconditional call to kfree() >> on common was performed in error recovery which is not a valid >> behaviour since fsg_common structure is not always allocated by >> fsg_common_init(). >> >> To fix, the calls has been replaced with a goto to a proper error >> recovery which does the correct thing. >> >> Also, refactored fsg_common_release() function. >> >> Signed-off-by: Michal Nazarewicz <mina86@xxxxxxxxxx> Greg KH <greg@xxxxxxxxx> writes: > Does this superseed your previous patch in this thread? Yes. The difference is with fsg_common_release() function which is purely a style change. -- Best regards, _ _ .o. | Liege of Serenly Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +--<mina86-tlen.pl>--<jid:mina86-jabber.org>--ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html