Hi Wolfgang, On Monday 10 May 2010 15:43, Wolfgang Grandegger wrote: > Hi Matthias, > > On 05/10/2010 03:28 PM, Matthias Fuchs wrote: > > This patch adds a driver for esd's USB high speed > > CAN interface. The driver supports devices with > > multiple CAN interfaces. > > > > Signed-off-by: Matthias Fuchs <matthias.fuchs@xxxxxx> > > --- > > > > version 2: > > - use bus-error reporting and counters > > I don't find support for CAN_CTRLMODE_BERR_REPORTING, apart from setting > the flag. If it's set bus error interrupts should be enabled or disabled > otherwise. > > Wolfgang. I expect my implementation to be complete. 1) In esd_usb2_rx_event() I pass tx/rxerr in cf->data[6/7]. 2) I implemented esd_usb2_get_berr_counter(). This function will return the last tx/rx error counters from the hardware that are kept in priv->bec. 3) tx/rx error counter cannot be requested from the hardware so they are stored in priv->bec when they are received from the hardware. There is no way to enable or disable this behavior. 4) Finally I enabled the whole interface via CAN_CTRLMODE_BERR_REPORTING for the CAN framework. I don't see where I missed anything. Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
