Dear Mr. Bergmann, 2010/4/26 Arnd Bergmann <arnd@xxxxxxxx>: >> >> BKL is not needed here because necessary locking is already provided >> >> by mutex sisusb->lock. [...] > What about the BKL in the sisusb_ioctl()? It seems to follow the > same logic, so I would think that you can simply remove the BKL > from the module entirely, rather than only half of it. It is what effectively I'm trying to do! The first part of this work is already present in USB subsystem maintainer tree (aka greg) at: http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/usb/usb-sisusbvga-remove-the-bkl-from-ioctl.patch Ciao, Alessio -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html