On Monday 26 April 2010, Alessio Igor Bogani wrote: > 2010/4/26 Oliver Neukum <oneukum@xxxxxxx>: > > Am Sonntag, 25. April 2010 12:37:10 schrieb Alessio Igor Bogani: > >> BKL is not needed here because necessary locking is already provided > >> by mutex sisusb->lock. > > > > Have you checked the fb layer doesn't need it? > > The _open and _release functions are already serialized with mutex in > fb layer. So that mutex could be removed but in my opinion this job > should be done in a separate patch (like I have done some time ago for > nvidiafb driver). Now I would want suggest to remove BKL here only. What about the BKL in the sisusb_ioctl()? It seems to follow the same logic, so I would think that you can simply remove the BKL from the module entirely, rather than only half of it. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
