On Thu, 2010-04-22 at 14:00 -0700, Sarah Sharp wrote:
> On Tue, Apr 20, 2010 at 05:55:12PM +0800, Libin Yang wrote:
> > @@ -1335,6 +1361,85 @@ static int handle_tx_event(struct xhci_hcd *xhci,
> > }
> > }
> > }
> > + } else if (usb_endpoint_xfer_isoc(&td->urb->ep->desc)) {
> > + int idx;
> > + int len;
>
> You need to set len = 0 here. I get this warning:
> drivers/usb/host/xhci-ring.c: In function ‘handle_tx_event’:
> drivers/usb/host/xhci-ring.c:1414: warning: ‘len’ may be used uninitialized in this function
>
> > + len +=
> > + TRB_LEN(cur_trb->generic.field[2]);
> > + }
> > + len += TRB_LEN(cur_trb->generic.field[2]) -
> > + TRB_LEN(event->transfer_len);
>
> You use it here, uninitialized, for the first pass through the for loop.
> Please fix.
Sure.
Andiry Xu
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
