On Wed, 21 Apr 2010 17:38:22 +0200, <fabien.chouteau@xxxxxxxxx> wrote:
From: Fabien Chouteau <fabien.chouteau@xxxxxxxxx> Signed-off-by: Fabien Chouteau <fabien.chouteau@xxxxxxxxx>
Commit message missing, in both patches. It should contain some details on what the patch does and how this can be used.
@@ -2412,7 +2451,6 @@ static void fsg_disable(struct usb_function *f) raise_exception(fsg->common, FSG_STATE_CONFIG_CHANGE); } -
This is not important, but if you are going to resend the patch, how about not deleting this line?
/*-------------------------------------------------------------------------*/ static void handle_exception(struct fsg_common *common) @@ -2641,7 +2679,7 @@ static int fsg_main_thread(void *common_) /* Write permission is checked per LUN in store_*() functions. */ static DEVICE_ATTR(ro, 0644, fsg_show_ro, fsg_store_ro); static DEVICE_ATTR(file, 0644, fsg_show_file, fsg_store_file); - +static DEVICE_ATTR(ejected, 0444, fsg_show_ejected, NULL);
Same here. Otherwise, both patches look fine to me. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał "mina86" Nazarewicz (o o) ooo +---[mina86@xxxxxxxxxx]---[mina86@jabber.org]---ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
