On Tue, Apr 13, 2010 at 2:39 PM, Greg KH <greg@xxxxxxxxx> wrote: > On Tue, Apr 13, 2010 at 02:04:04PM +0100, Neil Jones wrote: >> From: Neil Jones <neiljay@xxxxxxxxx> >> Date: Mon, 12 Apr 2010 10:35:47 +0100 >> Subject: [PATCH] drivers/usb/gadget/f_mass_storage:?????? Send Reply for >> Get Max LUN request. >> >> The response to a control transfer request for maximimum no. of LUNs >> was not being sent. > > So this is needed to solve a bug for something? I need more details > please. > > thanks, > > greg k-h > Yes, I noticed on our USB analyzer when testing a new peripheral controller with the mass storage gadget that it was not responding to the request (a control transfer on EP0) to get the maximum number of LUNs supported by the device, I presume most people only use 1 LUN so don't see this problem, but it is a bug. Looking at the code I think the original author is assuming the response will be sent by the composite device driver see drivers/usb/gadget/composite.c lines 855-865, but the 'goto done' prevents the response from being sent, note you cannot remove the 'goto done' as other request have their responses handled in the function driver. Cheers Neil -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
