On Wed, Apr 07, 2010 at 12:52:10PM -0400, Alan Stern wrote: > On Wed, 7 Apr 2010, Sarah Sharp wrote: > > I don't like to have the usb_host_ss_ep_comp structure go away > > completely, as the USB core and the xHCI driver both use it. So there > > needs to be easy access to the descriptor without needing to re-parse > > the extra field every time. > > > > You could have the extra field in usb_host_endpoint encompass all the > > descriptors after the endpoint (including the SuperSpeed endpoint > > companion descriptor), and also keep a pointer to the > > usb_host_ss_ep_comp in usb_host_endpoint. I would be fine with that. > > There already _is_ a pointer to the usb_host_ss_ep_comp in > usb_host_endpoint. I was proposing to replace it with a pointer to the > usb_ss_ep_comp_descriptor. If we do that then the usb_host_ss_ep_comp > wouldn't contain anything useful. Ok, yes, that sounds fine. Apparently I shouldn't reply to email before having my cup of tea. :) > > I really struggled with the descriptor parsing code to get it right, so > > I really don't ever want to touch that code again. Maybe someone else > > wants to take a shot at it? > > I can change it to do this. Parts of xhci-hcd would have to be changed > too. Ok, sure, just CC me on the patches and I'll see if I need to rebase the streams patches. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
