Greg, This patch is from the thread a few weeks ago. It seems very likely this entry isn't needed, and now that we have another disjoint entry for the same VID/PID, it's a good time to attempt a cleanup. We cannot get ahold of the original user to test for us, so we'll keep an eye out for regression reports. Full description below. Please apply. Signed-off-by: Phil Dibowitz <phil@xxxxxxxx> -- Phil Dibowitz phil@xxxxxxxx Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
It seems unlikely that this entry is needed anymore since the kernel has logic to handle devices that poorly respond to INQUIRY. Since we now have another entry with the same VID/PID but different flags, it's a good time to attempt to clean this up. The original submitter's email no longer works, so we'll keep an eye out for any regression reports. Signed-off-by: Phil Dibowitz <phil@xxxxxxxx> --- linux-2.6.33-rc4-dev-phil/drivers/usb/storage/unusual_devs.h | 9 --------- 1 file changed, 9 deletions(-) diff -puN drivers/usb/storage/unusual_devs.h~unusual_dev_remove_old_sl11r drivers/usb/storage/unusual_devs.h --- linux-2.6.33-rc4-dev/drivers/usb/storage/unusual_devs.h~unusual_dev_remove_old_sl11r 2010-04-04 14:18:02.000000000 +0200 +++ linux-2.6.33-rc4-dev-phil/drivers/usb/storage/unusual_devs.h 2010-04-04 14:18:02.000000000 +0200 @@ -365,15 +365,6 @@ UNUSUAL_DEV( 0x04cb, 0x0100, 0x0000, 0x "FinePix 1400Zoom", US_SC_UFI, US_PR_DEVICE, NULL, US_FL_FIX_INQUIRY | US_FL_SINGLE_LUN), -/* Reported by Peter Wächtler <pwaechtler@xxxxxxxxxxxxx> - * The device needs the flags only. - */ -UNUSUAL_DEV( 0x04ce, 0x0002, 0x0074, 0x0074, - "ScanLogic", - "SL11R-IDE", - US_SC_DEVICE, US_PR_DEVICE, NULL, - US_FL_FIX_INQUIRY), - /* Reported by Kriston Fincher <kriston@xxxxxxxxxxx> * Patch submitted by Sean Millichamp <sean@xxxxxxxxxxx> * This is to support the Panasonic PalmCam PV-SD4090 _
Attachment:
signature.asc
Description: OpenPGP digital signature
