On Fri, Apr 02, 2010 at 11:26:23AM -0400, Alan Stern wrote: > On Fri, 2 Apr 2010, Hrant Dalalyan wrote: > > > > > Implementation of USB Attached SCSI Protocol per UASP Specification > > > > (Rev.1, July 9, 2008). Below is the list of the enhancements made to > > > > the usb-storage driver. > > > > > > In my opinion the UAS protocol is so different from the older USB > > > mass-storage protocols (it has almost nothing in common) that you'd be > > > better off writing a whole new driver instead of grafting this stuff > > > onto usb-storage. > > Yes, I agree with you. But the reason of adding the UASP support to the > > usb-storage driver is that the usb-storage contains the most common > > and well-known protocol implementations, e.g. CBI, CB, BBB. > > Sorry, that's not a good argument. It's like saying that support for > PPP should be added to the Ethernet driver because the Ethernet driver > contains the most common and well-known networking protocol > implementation. I agree with Alan. That argument would only make sense if we didn't have module auto-loading capabilities, which we've had for years now. > > The second > > reason is the code reuse. > > Well, in the end you didn't reuse much code. Lots of stuff was added > and lots of existing routines were changed, but not much of the > existing code is on the UASP path. Again, I agree with Alan. That said, if someone wanted to enhance usb-storage into an event-driven model, then UASP would actually share all the framework. > > But if there is a need to make it standalone > > then, considering the UASP class design and implementation, it'll be > > not so hard work to implement. > > Yes, please do. I think the final result will be greatly superior. Either make it standalone or put the effort in to enhance usb-storage to an event model. Modifying usb-storage probably only makes sense if Mass Storage Class ever actually adds TCQ. Given that we now have UASP, I kinda doubt that will happen. Then again, I'm no longer on USB-IF, so I really don't know. Matt -- Matthew Dharm Home: mdharm-usb@xxxxxxxxxxxxxxxxxx Maintainer, Linux USB Mass Storage Driver G: Money isn't everything, A.J. AJ: Who convinced you of that? G: The Chief, at my last salary review. -- Mike and Greg User Friendly, 11/3/1998
Attachment:
pgpKPRXRDy4O3.pgp
Description: PGP signature
