RE: [PATCH/RFC] UASP enhancement to usb-storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2 Apr 2010, Hrant Dalalyan wrote:

> > > Implementation of USB Attached SCSI Protocol per UASP Specification
> > > (Rev.1, July 9, 2008).  Below is the list of the enhancements made to
> > > the usb-storage driver.
> > 
> > In my opinion the UAS protocol is so different from the older USB
> > mass-storage protocols (it has almost nothing in common) that you'd be
> > better off writing a whole new driver instead of grafting this stuff
> > onto usb-storage.
> Yes, I agree with you. But the reason of adding the UASP support to the
> usb-storage driver is that the usb-storage contains the most common
> and well-known protocol implementations, e.g. CBI, CB, BBB.

Sorry, that's not a good argument.  It's like saying that support for 
PPP should be added to the Ethernet driver because the Ethernet driver
contains the most common and well-known networking protocol 
implementation.

> The second
> reason is the code reuse.

Well, in the end you didn't reuse much code.  Lots of stuff was added
and lots of existing routines were changed, but not much of the
existing code is on the UASP path.

> But if there is a need to make it standalone
> then, considering the UASP class design and implementation, it'll be 
> not so hard work to implement.

Yes, please do.  I think the final result will be greatly superior.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux