On Tue, 30 Mar 2010, Bruno Prémont wrote: > > so please either remove the parts that depend on power management for > > now, or I'll wait on your respin of the generic HID-PM patch. > > Here I respin the whole series, with PM moved to patch n°8 and > patch n°7 being my original generic HID-PM. Thanks! > Without the PM part there is one compiler warning about defined but > unused function (picolcd_resume_backlight), I hope this is not an issue. > If it is that function can move over to the PM patch (with it's stub for > !CONFIG_BACKLIGHT_CLASS_DEVICE case) It's actually picolcd_suspend_backlight(), the resume function is called from debugfs-triggered reset write. I have removed it from the patch for now, it should better be added when being used (i.e. when the proper PM support goes in as well). > So for now you can skip the last two patches during merge. I have applied patches 1-6 to my tree. So please base any further additions to the driver on the version that's in my tree now (picolcd and for-next branches). > Do you have any suggestions regarding generic HID-PM as to how much > and how it should be visible to the HID driver? I will look into the patch you have sent and comment on that shortly separately. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
