RE: [PATCH] usb: dummy_hcd: remove net2280_set_fifo_mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alan Stern wrote:
> On Mon, 29 Mar 2010, Anand Gadiyar wrote:
> 
> > Nothing in current kernel code calls this function,
> > and I don't think a net2280 fifo_mode setting belongs
> > in dummy_hcd - maybe a copy-paste remnant?
> 
> It's not a copy-paste remnant; the routine was put there on purpose.  
> It was meant to provide the same interface as net2280_set_fifo_mode()  
> in the net2280 driver.  If you're going to remove one, you might as
> well remove the other.
> 

I wasn't sure if I should touch that one. I'm not sure if there are
out of kernel modules that call this function, but I suppose they can
add it back if needed.

If no one objects, I'll send out a patch in a few days removing
both.

- Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux