On 03/28/2010 08:44 PM, Ben Hutchings wrote:
On Sun, 2010-03-28 at 15:12 -0400, Stephen Clark wrote:
On 03/28/2010 11:57 AM, Marcel Holtmann wrote:
Hi Elina,
+static const struct driver_info sierra_net_info_68A3 = {
+ .description = "Sierra Wireless USB-Ethernet Modem",
+ .flags = FLAG_ETHER | FLAG_SEND_ZLP,
+ .bind = sierra_net_bind,
+ .unbind = sierra_net_unbind,
+ .status = sierra_net_status,
+ .rx_fixup = sierra_net_rx_fixup,
+ .tx_fixup = sierra_net_tx_fixup,
+ .data = (unsigned long)&sierra_net_info_data_68A3,
+};
the FLAG_ETHER is wrong here. Please use FLAG_WWAN to clearly mark these
interfaces.
Otherwise we have wrong DEVTYPE uevent assignments and userspace will
treat them as real Ethernet cards. And that should not happen. As a nice
Why shouldn't that happen if they look like NIC cards?
[...]
This information is important for management interfaces. The user
doesn't care what your device looks like at the kernel level - they know
it's a wireless broadband device and they expect to see a device
labelled as such in Network Manager or whatever they use.
Ben.
You sound like a windows guy! Whats with everything having to use
NetworkManager!? Are people so dumb they can't figure things out from
the command line. If it acts like a NIC it should be a NIC. I am
so tired of eveyone trying to make Linux look and act like WINBLOWS.
--
"They that give up essential liberty to obtain temporary safety,
deserve neither liberty nor safety." (Ben Franklin)
"The course of history shows that as a government grows, liberty
decreases." (Thomas Jefferson)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
