On 03/28/2010 11:57 AM, Marcel Holtmann wrote:
Hi Elina,+static const struct driver_info sierra_net_info_68A3 = { + .description = "Sierra Wireless USB-Ethernet Modem", + .flags = FLAG_ETHER | FLAG_SEND_ZLP, + .bind = sierra_net_bind, + .unbind = sierra_net_unbind, + .status = sierra_net_status, + .rx_fixup = sierra_net_rx_fixup, + .tx_fixup = sierra_net_tx_fixup, + .data = (unsigned long)&sierra_net_info_data_68A3, +};the FLAG_ETHER is wrong here. Please use FLAG_WWAN to clearly mark these interfaces. Otherwise we have wrong DEVTYPE uevent assignments and userspace will treat them as real Ethernet cards. And that should not happen. As a nice
Why shouldn't that happen if they look like NIC cards?
benefit the interface name will be wwan%d by default as well. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
-- "They that give up essential liberty to obtain temporary safety, deserve neither liberty nor safety." (Ben Franklin) "The course of history shows that as a government grows, liberty decreases." (Thomas Jefferson) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
