Aguirre, Sergio wrote:
> > +static void setup_ohci_io_mux(enum ohci_omap3_port_mode *port_mode)
> > +{
> > + /* REVISIT: these need to be tailored for each of the modes */
> > + switch (port_mode[0]) {
> > + case OMAP_OHCI_PORT_MODE_PHY_3PIN_DATSE0:
> > + case OMAP_OHCI_PORT_MODE_PHY_4PIN_DPDM:
> > + omap_mux_init_signal("mm1_rxdp",
> > + OMAP_PIN_INPUT_PULLDOWN);
> > + omap_mux_init_signal("mm1_rxdm",
> > + OMAP_PIN_INPUT_PULLDOWN);
> > + omap_mux_init_signal("mm1_txse0",
> > + OMAP_PIN_INPUT_PULLDOWN);
> > + omap_mux_init_signal("mm1_rxrcv",
> > + OMAP_PIN_INPUT_PULLDOWN);
> > + omap_mux_init_signal("mm1_txdat",
> > + OMAP_PIN_INPUT_PULLDOWN);
> > + omap_mux_init_signal("mm1_txen_n", OMAP_PIN_OUTPUT);
> > + break;
> > + case OMAP_OHCI_PORT_MODE_UNUSED:
> > + default:
> > + /* FALLTHROUGH */
>
> Is this the right place for the fall through comment? I guess you meant
> Between 'case OMAP_OHCI_PORT_MODE_UNUSED:' and "default:" lines...
>
Ah yes, thanks for catching that.
By the way, I did sort out the 2/3/4/6-pin layout, so in the next version,
I'll be able to cover that cleanly.
- Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
