Re: [PATCH] AM35x: Add musb support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Gupta, Ajay Kumar wrote:
-----Original Message-----
From: Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxx]
Sent: Monday, March 22, 2010 4:33 PM
To: Gupta, Ajay Kumar
Cc: Sergei Shtylyov; linux-omap@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] AM35x: Add musb support

Gupta, Ajay Kumar wrote:

I have not added CPPI4.1 DMA  specific register here..



   Ah. Then they're not compatible with DA8xx anyway...


We could make it compatible with some change as done at,
http://arago-project.org/git/people/?p=sriram/ti-psp-

omap.git;a=commitdiff;h=2ecce9529bd56c32997e0b2cbe84f7727ba5b217

I'm not sure where cppi41_dma.c gets the definitions for
USB_[RT]X_MODE_REG...

It is being used from plat/usb.h.

   I haven't found where it's included.

It's from cppi41_dma.h.

Well, you've removed the register #define's from cppi41_dma.h and #includ'ed <plat/usb.h> BUT there's certainly no such header for DA8xx , so as I suspected you've broken DA8xx support. That certainly won't do. :-/

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux