Hi,
On Thu, Mar 11, 2010 at 07:27:29PM +0100, ext Alan Cox wrote:
What we did (as a hack, but I want to finish the patch and send as RFC)
is make ->receive_buf() return the amount of bytes received. Then we can
get rid of ->receive_room.
Which is not be a bad idea anyway, irrespective of the underlying
problem - which I suspect is some kind of n_tty internal disagreement
with itself.
I see.
It's not perfect, but it help us a lot. I still don't know why the
receive_room approach was taken if it would be a lot simpler (at
least IMO)to let receive_buf() return the amount of received bytes.
receive_room is historical to the extent it goes back to very early
kernels and I've no idea why it was done that way. I have no problem with
making it go away.
good. I'll try to extend this patch to the other ldiscs and also get rid
of receive_room. It'll take a while for the fully test it though.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
