Re: [RFC/PATCH 1/2] usb: gadget: u_char: introduce chardev abstraction layer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > we experienced several problems with tty layer. The biggest of them is
> > a race between flush_to_ldisc() and ->receiv_buf() which makes the line
> > discipline (I guess only n_tty) loose bytes in some circumstances.
> 
> That sounds like a bug we need to fix then, right?

It sounds like a bug that someone needs to provide a test case and
explanation for. The underlying buffering logic appears solid up to about
40MB/sec (beyond that the existing buffer settings and round trip time
for flow control would need addressing and possibly some data handling).

I don't see any real value in a char abstraction for most of the cases
where we hit performance and other problems - a packet abstraction ought
to be both a lot faster and provide a more flexible interface for
stuff where usb frame boundaries matter.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux