On Sat, Feb 27, 2010 at 05:26:21PM +0300, Sergei Shtylyov wrote:
> Johan Hovold wrote:
> > Resubmitting read urb fails with -EPERM if completion handler runs while
> > urb is being killed on close. This should not be reported as an error.
> >
> > Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>
> > ---
> > drivers/usb/serial/generic.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
> > index 89fac36..e560d1d 100644
> > --- a/drivers/usb/serial/generic.c
> > +++ b/drivers/usb/serial/generic.c
> > @@ -415,11 +415,13 @@ void usb_serial_generic_resubmit_read_urb(struct usb_serial_port *port,
> > ((serial->type->read_bulk_callback) ?
> > serial->type->read_bulk_callback :
> > usb_serial_generic_read_bulk_callback), port);
> > +
> > result = usb_submit_urb(urb, mem_flags);
> > - if (result)
> > + if (result && result != -EPERM) {
> > dev_err(&port->dev,
> > "%s - failed resubmitting read urb, error %d\n",
> > __func__, result);
> > + }
> >
>
> Why did you add {} here? Have you run your patch thru checkpatch.pl?
Yes -- checkpatch reports no errors or warnings.
I know a single statement does not require braces, but if that single
statement extends over three lines I would argue that the braces do
indeed improve readability.
/Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
