Re: [PATCH 01/07]usb: cdc-wdm: Fix race between write and disconnect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 17, 2010 at 04:01:27PM +0100, Oliver Neukum wrote:
> >From 6dd0092cdb010a5dadc94809a63ff4f5240ed5c8 Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oliver@xxxxxxxxxx>
> Date: Tue, 9 Feb 2010 16:40:27 +0100
> Subject: [PATCH 1/6] usb: cdc-wdm: Fix race between write and disconnect
> 
> Unify mutexes to fix a race between write and disconnect
> and shift the test for disconnection to always report it.
> 
> Signed-off-by: Oliver Neukum <neukum@xxxxxxxxxxxxx>
> ---
>  drivers/usb/class/cdc-wdm.c |   84 +++++++++++++++++++++++--------------------
>  1 files changed, 45 insertions(+), 39 deletions(-)
> 
> diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c
> index 3e564bf..e1d6b82 100644
> --- a/drivers/usb/class/cdc-wdm.c
> +++ b/drivers/usb/class/cdc-wdm.c
> @@ -87,9 +87,7 @@ struct wdm_device {
>  	int			count;
>  	dma_addr_t		shandle;
>  	dma_addr_t		ihandle;
> -	struct mutex		wlock;
> -	struct mutex		rlock;
> -	struct mutex		plock;
> +	struct mutex		lock;

Are you sure this is right?  It breaks the build right here, and then
the other patches don't seem to apply properly afterwards.

Can you respin all 6 of these to apply and build properly?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux