Re: [PATCH] USB: fix the idProduct value for USB-3.0 root hubs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 25, 2010 at 02:52:49PM -0500, Alan Stern wrote:
> On Thu, 25 Feb 2010, Sarah Sharp wrote:
> 
> > On Thu, Feb 25, 2010 at 01:19:37PM -0500, Alan Stern wrote:
> > > This patch (as1346) changes the idProduct value for USB-3.0 root hubs
> > > from 0x0002 (which we already use for USB-2.0 root hubs) to 0x0003.
> > > 
> > > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > > CC: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> > > CC: <stable@xxxxxxxxxx>
> > > 
> > > ---
> > > 
> > > This probably was a copy & paste error originally.
> > 
> > Not necessarily.  I need to check if khubd will work correctly with this
> > change.  I was trying to do the minimal amount of modification needed to
> > get the USB3 root hubs working, so the root hub descriptor for USB3 is
> > very similar to a USB2 root hub descriptor.
> 
> The hub driver matches based on the device or interface class, not the 
> product ID.  Changing the product ID won't hurt it.
> 
> With the existing code, lsusb calls an xHCI root hub a "Linux
> Foundation 2.0 root hub", the same as an EHCI root hub.  By contrast,
> UHCI and OHCI are reported as "Linux Foundation 1.1 root hub".

Yep, I checked, you're right. :)

Acked-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux