Re: [Bugme-new] [Bug 15376] New: regression (oops) with usb in 2.6.33-rc8

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 24 Feb 2010, Sarah Sharp wrote:

> The only way you would get a null pointer deference when
> usb_altnum_to_altsetting() is called in usb_reset_configuration() is if
> usb_host_config->interface[i] is null.  I think that's only true if the
> configuration is not active, meaning the device was in the addressed
> state.
> 
> Alan, does this sound correct?

It does.  However usb_reset_configuration() doesn't get called if 
actconfig is NULL.

> I think the fix is to dig the interfaces out of the interface cache
> instead.  I'll post a patch in a bit.

No, that's not right.  The interface cache isn't needed; 
usb_reset_configuration() should never be called if there isn't an 
active configuration -- it would make no sense.

Instead find out exactly what's going wrong.  Write a debugging patch
to print actconfig and actconfig->desc.bNumInterfaces in
proc_setconfig(), and print intf in usb_reset_configuration().

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux