On Thu, 25 February 2010 Oliver Neukum <oliver@xxxxxxxxxx> wrote: > Am Mittwoch, 24. Februar 2010 17:01:12 schrieb Bruno Prémont: > > Add suspend/resume hooks for HID drivers so these can do some > > additional state adjustment when device gets suspended/resumed. > > > > This patch calls these hooks from usbhid suspend/resume functions, > > only calling suspend on plain suspend, not autosuspend. > > (it might be worth adding an autosuspend parameter to suspend > > hook and calling suspend in both cases) > > This is quite dirty. Yeah, it covers what I did need (at least for success path). For the rest I was expecting feedback (and probably should have labeled the patch RFC) > A driver that was autosuspended may be non-auto resumed. Secondly, do > you really want to call the hook for reset_resume() if > hid_post_reset() has failed? Possibly not though depending on why hid_post_reset failed the first USB operation would fail as well, thus it would fall under "normal" error conditions for the driver... Opinion of USB/HID experts is welcome! > Regards > Oliver Thanks for the review! Regards, Bruno -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
