> -----Original Message----- > From: Oliver Neukum [mailto:oliver@xxxxxxxxxx] > Sent: Thursday, February 25, 2010 8:22 AM > To: Gupta, Ajay Kumar > Cc: linux-usb@xxxxxxxxxxxxxxx; Alan Stern > Subject: Re: [RFC] musb: Add workqueue for request giveback > > Am Mittwoch, 24. Februar 2010 14:42:11 schrieb Ajay Kumar Gupta: > > Current musb host driver does the giveback of completed urb first and > > then start the next request. This is significantly affecting the > streaming > > from an USB camera wherein we observe huge delay between the two IN > tokens > > from musb host. This is due to the fact that UVC driver is doing > decoding > > and further processing in giveback context. > > > > The patch tries to defer the giveback part to a workqueue and continues > > with the start of new request in completion path. > > I am afraid this is conceptually broken. Drivers are supposed to be able > to evaluate the response and do error handling before the next URB > is processed. Oliver, Error handling is already done before the actual giveback which is handled in workqueue so I think this should be fine. -Ajay > > Regards > Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
