[Patch] usbmon: mask seconds properly in text API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The code does not implement the comment, so timestamps for long traces
become confusing instead of wrapping neatly as expected. This was actually
observed. Fortunately for API being in debugfs, we can just fix this instead
of staying bug-for-bug compatible. Double fortunately, the stable binary
API is not affected.

Signed-Off-By: Pete Zaitcev <zaitcev@xxxxxxxxxx>

---
 drivers/usb/mon/mon_text.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 1cd822cf5022d58d28f0dbc89b431635fbd2c4be
Author: Master <zaitcev@xxxxxxxxxxxxxxxxxx>
Date:   Fri Feb 19 22:30:53 2010 -0700

    Fix timestamp wrapping.

diff --git a/drivers/usb/mon/mon_text.c b/drivers/usb/mon/mon_text.c
index 16bfb61..31c1188 100644
--- a/drivers/usb/mon/mon_text.c
+++ b/drivers/usb/mon/mon_text.c
@@ -180,7 +180,7 @@ static inline unsigned int mon_get_timestamp(void)
 	unsigned int stamp;
 
 	do_gettimeofday(&tval);
-	stamp = tval.tv_sec & 0xFFFF;	/* 2^32 = 4294967296. Limit to 4096s. */
+	stamp = tval.tv_sec & 0xFFF;	/* 2^32 = 4294967296. Limit to 4096s. */
 	stamp = stamp * 1000000 + tval.tv_usec;
 	return stamp;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux