Re: Question: USBserial suspend/resume issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 19 Feb 2010, Martin Chaplet wrote:

> Hi,
> 
> I did a little fix for this in ftdi driver for 2.6.27 kernel ... perhaps it can
> help.
> Here is the patch:

...

> +static int ftdi_suspend(struct usb_serial *serial, pm_message_t message)
> +{
> +	struct usb_serial_port *port;
> +	struct ftdi_private *priv; //= usb_get_serial_port_data(port);
> +	int i;
> +
> +	/* Multi-port compatibility (even if generally, there is only one port by
> 'chip') */
> +	for (i = 0; i < serial->num_ports; i++) {
> +		port = serial->port[i];
> +		priv = usb_get_serial_port_data(port);
> +
> +		/* TODO: Check for Flow control and disable it if necessary */
> +
> +		/* cancel any scheduled reading */
> +		cancel_delayed_work(&priv->rx_work);
> +		flush_scheduled_work();

flush_scheduled_work() shouldn't be used in drivers.  Use
cancel_delayed_work_sync() instead.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux