Re: [PATCH 5/8 v2] powerpc/mpc5121: add USB host support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 27, 2010 at 5:07 AM, Anatolij Gustschin <agust@xxxxxxx> wrote:
> Platform specific code for MPC5121 USB Host support.
> MPC5121 Rev 2.0 silicon EHCI registers are big endian.
> Add appropriate support by specifying "fsl,big-endian-regs"
> property in device tree node for USB controller. Also
> allow specifying DRVVBUS and PWR_FAULT signal polarity
> of the MPC5121 internal PHY using "fsl,invert-drvvbus" and
> "fsl,invert-pwr-fault" properties.
[...]
> --- a/Documentation/powerpc/dts-bindings/fsl/usb.txt
> +++ b/Documentation/powerpc/dts-bindings/fsl/usb.txt
> @@ -33,6 +33,14 @@ Recommended properties :
>  - interrupt-parent : the phandle for the interrupt controller that
>    services interrupts for this device.
>
> +Optional properties :
> + - fsl,big-endian-regs : boolean; if defined, indicates the USB host
> +   controller registers format is big endian.

As commented in previous thread, this property should be dropped, and
the driver should test for fsl,mpc5121-usb2-dr directly.  fsl-usb2-dr
should also be dropped from the compatible list of the .dts file.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux