On Mon, Jan 25, 2010 at 10:00 AM, Anatolij Gustschin <agust@xxxxxxx> wrote: > On Thu, 21 Jan 2010 10:43:34 -0700 > Grant Likely <grant.likely@xxxxxxxxxxxx> wrote: > >> > diff --git a/Documentation/powerpc/dts-bindings/fsl/usb.txt b/Documentation/powerpc/dts-bindings/fsl/usb.txt >> > index b001524..9050154 100644 >> > --- a/Documentation/powerpc/dts-bindings/fsl/usb.txt >> > +++ b/Documentation/powerpc/dts-bindings/fsl/usb.txt >> > @@ -33,6 +33,14 @@ Recommended properties : >> > - interrupt-parent : the phandle for the interrupt controller that >> > services interrupts for this device. >> > >> > +Optional properties : >> >> > + - big-endian-regs : boolean; if defined, indicates the USB host >> > + controller registers format is big endian. >> >> Rather than testing for this explicitly, add fsl,mpc5121-usb2-dr to >> the match table and use the .data pointer for setting device specific >> quirks. Still, don't use a new property to describe this. The regs being big-endian is all wrapped up in the definition of what fsl,mpc5121-usb2-dr means. You should also drop fsl-usb2-dr from the compatible list in the .dts file since this device is *not* compatible with it due to the endian difference. Test for fsl,mpc5121-usb2-dr explicitly, and adapt the driver behaviour accordingly. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
