On Tue, Jan 26, 2010 at 06:00:26AM +0100, Marcel Holtmann wrote:
> Hi Greg,
>
> > The problem with Ethernet based networking devices is to clearly
> > identify what's their usage. Special interfaces like bridges, WiFi,
> > Bluetooth, WiMAX or WWAN are already using DEVTYPE identification.
> >
> > This patch marks the Ethernet functions of gadgets from the device
> > type "gadget". Automatic setup of these interfaces can now happen
> > from userspace without the need of hardcoding the network interface
> > name.
> >
> > Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> > ---
> > drivers/usb/gadget/u_ether.c | 5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/u_ether.c b/drivers/usb/gadget/u_ether.c
> > index 2fc02bd..84ca195 100644
> > --- a/drivers/usb/gadget/u_ether.c
> > +++ b/drivers/usb/gadget/u_ether.c
> > @@ -746,6 +746,10 @@ static const struct net_device_ops eth_netdev_ops = {
> > .ndo_validate_addr = eth_validate_addr,
> > };
> >
> > +static struct device_type gadget_type = {
> > + .name = "gadget",
> > +};
> > +
> > /**
> > * gether_setup - initialize one ethernet-over-usb link
> > * @g: gadget to associated with these links
> > @@ -808,6 +812,7 @@ int __init gether_setup(struct usb_gadget *g, u8 ethaddr[ETH_ALEN])
> >
> > dev->gadget = g;
> > SET_NETDEV_DEV(net, &g->dev);
> > + SET_NETDEV_DEVTYPE(net, &gadget_type);
> >
> > status = register_netdev(net);
> > if (status < 0) {
>
> this patch is pretty much straight forward. Any issues with it?
No, sorry, it's in my queue, should get to it tomorrow or the next.
-stable work is taking up lots of my time recently...
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
