Re: [PATCH 1/2] USB: serial: option: add Telit Cinterion FE990B compositions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il giorno mar 4 mar 2025 alle ore 09:56 Daniele Palmas
<dnlplm@xxxxxxxxx> ha scritto:
>
> Hello Fabio,
>
> Il giorno gio 27 feb 2025 alle ore 12:08 Fabio Porcedda
> <fabio.porcedda@xxxxxxxxx> ha scritto:
> >
> > Add the following Telit Cinterion FE990B40 compositions:
> >
> > 0x10b0: rmnet + tty (AT/NMEA) + tty (AT) + tty (AT) + tty (AT) +
> >         tty (diag) + DPL + QDSS (Qualcomm Debug SubSystem) + adb
> > T:  Bus=01 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  7 Spd=480  MxCh= 0
> > D:  Ver= 2.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> > P:  Vendor=1bc7 ProdID=10b0 Rev=05.15
> > S:  Manufacturer=Telit Cinterion
> > S:  Product=FE990
> > S:  SerialNumber=28c2595e
> > C:  #Ifs= 9 Cfg#= 1 Atr=e0 MxPwr=500mA
> > I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=50 Driver=qmi_wwan
> > E:  Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=82(I) Atr=03(Int.) MxPS=   8 Ivl=32ms
> > I:  If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=60 Driver=option
> > E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=84(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
> > E:  Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=86(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
> > E:  Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=88(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
> > E:  Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=8a(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option
> > E:  Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=8b(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 6 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=80 Driver=(none)
> > E:  Ad=8c(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 7 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=70 Driver=(none)
> > E:  Ad=8d(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 8 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
> > E:  Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=8e(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> >
> > 0x10b1: MBIM + tty (AT/NMEA) + tty (AT) + tty (AT) + tty (AT) +
> >         tty (diag) + DPL + QDSS (Qualcomm Debug SubSystem) + adb
> > T:  Bus=01 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  8 Spd=480  MxCh= 0
> > D:  Ver= 2.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> > P:  Vendor=1bc7 ProdID=10b1 Rev=05.15
> > S:  Manufacturer=Telit Cinterion
> > S:  Product=FE990
> > S:  SerialNumber=28c2595e
> > C:  #Ifs=10 Cfg#= 1 Atr=e0 MxPwr=500mA
> > I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0e Prot=00 Driver=cdc_mbim
> > E:  Ad=82(I) Atr=03(Int.) MxPS=  64 Ivl=32ms
> > I:  If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim
> > E:  Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=60 Driver=option
> > E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=84(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
> > E:  Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=86(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
> > E:  Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=88(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 5 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
> > E:  Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=8a(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option
> > E:  Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=8b(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 7 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=80 Driver=(none)
> > E:  Ad=8c(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 8 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=70 Driver=(none)
> > E:  Ad=8d(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 9 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
> > E:  Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=8e(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> >
> > 0x10b2: RNDIS + tty (AT/NMEA) + tty (AT) + tty (AT) + tty (AT) +
> >         tty (diag) + DPL + QDSS (Qualcomm Debug SubSystem) + adb
> > T:  Bus=01 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  9 Spd=480  MxCh= 0
> > D:  Ver= 2.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> > P:  Vendor=1bc7 ProdID=10b2 Rev=05.15
> > S:  Manufacturer=Telit Cinterion
> > S:  Product=FE990
> > S:  SerialNumber=28c2595e
> > C:  #Ifs=10 Cfg#= 1 Atr=e0 MxPwr=500mA
> > I:  If#= 0 Alt= 0 #EPs= 1 Cls=ef(misc ) Sub=04 Prot=01 Driver=rndis_host
> > E:  Ad=82(I) Atr=03(Int.) MxPS=   8 Ivl=32ms
> > I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=rndis_host
> > E:  Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=60 Driver=option
> > E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=84(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
> > E:  Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=86(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
> > E:  Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=88(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 5 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
> > E:  Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=8a(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option
> > E:  Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=8b(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 7 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=80 Driver=(none)
> > E:  Ad=8c(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 8 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=70 Driver=(none)
> > E:  Ad=8d(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 9 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
> > E:  Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=8e(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> >
> > 0x10d3: ECM + tty (AT/NMEA) + tty (AT) + tty (AT) + tty (AT) +
> >         tty (diag) + DPL + QDSS (Qualcomm Debug SubSystem) + adb
>
> Shouldn't this be 0x10b3 ?

Yes, I've sent a v2 to fix it.

Thanks,
Fabio

> The rest looks good to me.
>
> Regards,
> Daniele
>
> > T:  Bus=01 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 11 Spd=480  MxCh= 0
> > D:  Ver= 2.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> > P:  Vendor=1bc7 ProdID=10b3 Rev=05.15
> > S:  Manufacturer=Telit Cinterion
> > S:  Product=FE990
> > S:  SerialNumber=28c2595e
> > C:  #Ifs=10 Cfg#= 1 Atr=e0 MxPwr=500mA
> > I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=06 Prot=00 Driver=cdc_ether
> > E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=32ms
> > I:  If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_ether
> > E:  Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=60 Driver=option
> > E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=84(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
> > E:  Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=86(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
> > E:  Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=88(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 5 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
> > E:  Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=8a(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> > I:  If#= 6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option
> > E:  Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=8b(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 7 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=80 Driver=(none)
> > E:  Ad=8c(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 8 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=70 Driver=(none)
> > E:  Ad=8d(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:  If#= 9 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
> > E:  Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E:  Ad=8e(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Fabio Porcedda <fabio.porcedda@xxxxxxxxx>
> > ---
> >  drivers/usb/serial/option.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > index 58bd54e8c483..8660f7a89b01 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -1388,6 +1388,22 @@ static const struct usb_device_id option_ids[] = {
> >           .driver_info = RSVD(0) | NCTRL(2) | RSVD(3) | RSVD(4) },
> >         { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x10aa, 0xff),    /* Telit FN920C04 (MBIM) */
> >           .driver_info = NCTRL(3) | RSVD(4) | RSVD(5) },
> > +       { USB_DEVICE_INTERFACE_PROTOCOL(TELIT_VENDOR_ID, 0x10b0, 0x60) },       /* Telit FE990B (rmnet) */
> > +       { USB_DEVICE_INTERFACE_PROTOCOL(TELIT_VENDOR_ID, 0x10b0, 0x40) },
> > +       { USB_DEVICE_INTERFACE_PROTOCOL(TELIT_VENDOR_ID, 0x10b0, 0x30),
> > +         .driver_info = NCTRL(5) },
> > +       { USB_DEVICE_INTERFACE_PROTOCOL(TELIT_VENDOR_ID, 0x10b1, 0x60) },       /* Telit FE990B (MBIM) */
> > +       { USB_DEVICE_INTERFACE_PROTOCOL(TELIT_VENDOR_ID, 0x10b1, 0x40) },
> > +       { USB_DEVICE_INTERFACE_PROTOCOL(TELIT_VENDOR_ID, 0x10b1, 0x30),
> > +         .driver_info = NCTRL(6) },
> > +       { USB_DEVICE_INTERFACE_PROTOCOL(TELIT_VENDOR_ID, 0x10b2, 0x60) },       /* Telit FE990B (RNDIS) */
> > +       { USB_DEVICE_INTERFACE_PROTOCOL(TELIT_VENDOR_ID, 0x10b2, 0x40) },
> > +       { USB_DEVICE_INTERFACE_PROTOCOL(TELIT_VENDOR_ID, 0x10b2, 0x30),
> > +         .driver_info = NCTRL(6) },
> > +       { USB_DEVICE_INTERFACE_PROTOCOL(TELIT_VENDOR_ID, 0x10b3, 0x60) },       /* Telit FE990B (ECM) */
> > +       { USB_DEVICE_INTERFACE_PROTOCOL(TELIT_VENDOR_ID, 0x10b3, 0x40) },
> > +       { USB_DEVICE_INTERFACE_PROTOCOL(TELIT_VENDOR_ID, 0x10b3, 0x30),
> > +         .driver_info = NCTRL(6) },
> >         { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x10c0, 0xff),    /* Telit FE910C04 (rmnet) */
> >           .driver_info = RSVD(0) | NCTRL(3) },
> >         { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x10c4, 0xff),    /* Telit FE910C04 (rmnet) */
> > --
> > 2.48.1
> >



-- 
Fabio Porcedda




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux