Kurt noticed a few problems with a USB 3.0 controller (he was the first to tell me about it being in a shipping product). One of them was the lack of a speed for the USB 3.0 controller. Sarah, what should we use here, a "real" bitrate, or just "super" for the speed? Can devices change speed when they are connected? Dave, is "variable" ok for wireless USB devices? thanks, greg k-h ----------- Subject: USB: add speed values for USB 3.0 and wireless controllers From: Greg Kroah-Hartman <gregkh@xxxxxxx> These controllers say "unknown" for their speed in sysfs, which obviously isn't correct. Reported-by: Kurt Garloff <garloff@xxxxxxxxxx> Cc: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> Cc: David Vrabel <david.vrabel@xxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx> --- a/drivers/usb/core/sysfs.c +++ b/drivers/usb/core/sysfs.c @@ -115,6 +115,12 @@ show_speed(struct device *dev, struct device_attribute *attr, char *buf) case USB_SPEED_HIGH: speed = "480"; break; + case USB_SPEED_VARIABLE: + speed = "variable"; + break; + case USB_SPEED_SUPER: + speed = "super"; + break; default: speed = "unknown"; } -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
