On Wed, 27 Nov 2024 09:45:30 +0100 Krzysztof Hałasa wrote: > To: netdev <netdev@xxxxxxxxxxxxxxx> > Cc: Oliver Neukum <oneukum@xxxxxxxx>, Andrew Lunn <andrew+netdev@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, linux-usb@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Jose Ignacio Tornos Martinez <jtornosm@xxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx> Please add to the CC list some folks who worked on phylib and phylink support for this driver. They will be best reviewers. > Subject: [PATCH] USBNET: Fix ASIX USB Ethernet carrier problems. No need to spell out USBNET in all caps. I'd rename the subject to: usbnet: asix: leave the carrier control to phylink If we say it's a 'fix' we should really point at the commit which broke things with a Fixes: tag. If your device never worked it's better to act as if it was "support for a new device". Otherwise various semi- -automated backport bots will suck this change in, and given the general dependability of ASIX devices... seems risky.. > Date: Wed, 27 Nov 2024 09:45:30 +0100 > Sender: khalasa@xxxxxxx > > Hi, No need to say "Hi" in the commit message :) -- pw-bot: cr