On Thu, Oct 17, 2024 at 11:25:20AM +0300, Abel Vesa wrote: > On 24-10-17 08:00:44, Johan Hovold wrote: > > I can confirm that marking the regulators as having been left on by the > > bootloader so that they are not disabled temporarily during boot indeed > > fixes the coldplug issue here. > > > > That however makes me wonder whether something is missing in the driver > > so that it still relies on setup having been done by the boot firmware. > > > > Have you tried actually asserting reset during probe to verify that > > driver can configure the retimers itself without relying on the boot > > firmware? > > We do not want to reset the retimers on probe because we won't be able > to figure out the orientation config until next pmic glink notify comes. > The pmic glink notify only triggers on USB event, which never comes > until you replug the device. So in order to have coldplug orientation > configured correctly in the retimer, we need to make sure the retimer > holds state until unplug. Ok, thanks for clarifying. As we've discussed off-list it should be possible to retrieve the orientation from the orientation gpios, but I'm sure there are bits missing in the kernel for propagating that information to the retimers currently. If I understood you correctly you did reset and reinitialise the retimers in v1, which is useful during development at least to make sure that the driver is complete. Johan
