On Mon, 4 Jan 2010, Rick L. Vinyard, Jr. wrote: > >> > This patch is against the torvalds/linux-2.6.git tree. > >> > >> Should this use auxdisplay framework and be located there? > > > > Well, the device is still primarily HID device in its nature, so either > > keeping the whole driver in drivers/hid, or separating it into two > > drivers, one for the HID part and second for the framebuffer part should > > be acceptable. > > The framebuffer part uses the same interrupt endpoint for both HID and > display. IIRC there were issues with two drivers using the same interrupt > endpoint. I have no objection to keeping this as a single driver in drivers/hid, provided that the framebuffer part gets reviewed by someone more familiar with the framebuffer code than I am. > > I will proceed with reviewing the driver soon, sorry for slightly higher > > latencies these days. > > No problem... as you can see my latency responding is rather high. Also please see the other thread about the build failures I am getting with this drivers (and it's not fixed solely by making the driver dependent on FB_DEFERRED_IO (namely it doesn't like to be built in as module, because of the symbol name clashes with hid-lg). Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
