On Tue, Sep 03, 2024 at 10:27:08AM +0200, Hans de Goede wrote: > Hi Greg, > > Thank you for the reviews. > > On 9/3/24 9:04 AM, Greg Kroah-Hartman wrote: > > On Sat, Aug 31, 2024 at 04:20:39PM +0200, Hans de Goede wrote: > >> The bit_types array just hold a list of valid enum power_supply_usb_type > >> values which map to 0 - 9. This can easily be represented as a bitmap. > >> > >> This reduces the size of struct power_supply_desc and further reduces > >> the data section size by drivers no longer needing to store the array. > >> > >> This also unifies how usb_types are handled with charge_behaviours, > >> which allows power_supply_show_usb_type() to be removed. > >> > >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > > > Nice! > > > > Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > I assume this also counts as an ack for merging this through > the linux-power-supply tree ? Yes please.
