Re: [PATCH v2 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 01, 2024 at 02:49:33PM +0300, Dmitry Baryshkov wrote:
> On Thu, Aug 01, 2024 at 02:49:05PM GMT, Xu Yang wrote:
> > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware
> > used for connecting, disconnecting and switching orientation of
> > the SuperSpeed lines in USB Type-C applications.
> > 
> > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf
> > 
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx>
> > 
> > ---
> > Changes in v2:
> >  - add Acked-by tag
> >  - s/SBU/SuperSpeed in commit message
> > ---
> >  Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> > index 8a5f837eff94..152849f744c1 100644
> > --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> > +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> > @@ -20,6 +20,7 @@ properties:
> >      items:
> >        - enum:
> >            - nxp,cbdtu02043
> > +          - nxp,ptn36043
> 
> PTN36043 isn't an SBU mux, so it is incorrect to declare that it is
> compatible with the "gpio-sbu-mux".

Well, so I should create a compatible such as "gpio-ss-mux" and make some
changes on the driver, right?

Thanks,
Xu Yang

> 
> >            - onnn,fsusb43l10x
> >            - pericom,pi3usb102
> >            - ti,tmuxhs4212
> > -- 
> > 2.34.1
> > 
> 
> -- 
> With best wishes
> Dmitry




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux