On Mon, Dec 21, 2009 at 11:23, Alan Stern wrote: > On Mon, 21 Dec 2009, Mike Frysinger wrote: > >> @@ -1272,12 +1273,12 @@ sl811h_hub_control( >> sl811h_hub_descriptor(sl811, (struct usb_hub_descriptor *) buf); >> break; >> case GetHubStatus: >> - *(__le32 *) buf = cpu_to_le32(0); >> + put_unaligned(cpu_to_le32(0), (__le32 *) buf); >> break; >> case GetPortStatus: >> if (wIndex != 1) >> goto error; >> - *(__le32 *) buf = cpu_to_le32(sl811->port1); >> + put_unaligned(cpu_to_le32(sl811->port1), (__le32 *) buf); > > How about using put_unaligned_le32() instead? Then the casts wouldn't > be needed. i guess it takes care of the cpu_to_le32 too so we'd only have to do: put_unaligned_le32(0, buf); put_unaligned_le32(sl811->port1, buf); -mike -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
