Re: [PATCH 1/2] usb/host: SL811: fix unaligned accesses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 21 Dec 2009, Mike Frysinger wrote:

> @@ -1272,12 +1273,12 @@ sl811h_hub_control(
>  		sl811h_hub_descriptor(sl811, (struct usb_hub_descriptor *) buf);
>  		break;
>  	case GetHubStatus:
> -		*(__le32 *) buf = cpu_to_le32(0);
> +		put_unaligned(cpu_to_le32(0), (__le32 *) buf);
>  		break;
>  	case GetPortStatus:
>  		if (wIndex != 1)
>  			goto error;
> -		*(__le32 *) buf = cpu_to_le32(sl811->port1);
> +		put_unaligned(cpu_to_le32(sl811->port1), (__le32 *) buf);

How about using put_unaligned_le32() instead?  Then the casts wouldn't 
be needed.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux