On Mon, 21 Dec 2009, Gadiyar, Anand wrote: > Hi, > > I notice that most of the ehci glue layer drivers call > ehci_port_power() only once, either to turn on the port > power, or to turn it off. > > Shouldn't these calls be balanced? In theory they should be, but the HCD glue layer doesn't make any callbacks at the right time. > Also, if a driver chooses not to call this function, then > we get a compile warning about ehci_port_power being defined > but not used. Is it okay to mark it as __maybe_unused? Yes. It doesn't matter much if a driver doesn't call ehci_port_power(), because the hub driver always turns on power to all ports when it initializes the root hub. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
