Hi, I notice that most of the ehci glue layer drivers call ehci_port_power() only once, either to turn on the port power, or to turn it off. Shouldn't these calls be balanced? Also, if a driver chooses not to call this function, then we get a compile warning about ehci_port_power being defined but not used. Is it okay to mark it as __maybe_unused? - Anand $ grep ehci_port_power *.c ehci-atmel.c: ehci_port_power(ehci, 0); ehci-au1xxx.c: ehci_port_power(ehci, 1); ehci-fsl.c: ehci_port_power(ehci, 0); ehci-hcd.c:static void ehci_port_power (struct ehci_hcd *ehci, int is_on) ehci-ixp4xx.c: ehci_port_power(ehci, 0); ehci-mxc.c: ehci_port_power(ehci, 0); ehci-orion.c: ehci_port_power(ehci, 0); ehci-pci.c: ehci_port_power(ehci, 1); ehci-pci.c: ehci_port_power(ehci, 1); oxu210hp-hcd.c:static void ehci_port_power(struct oxu_hcd *oxu, int is_on) oxu210hp-hcd.c: ehci_port_power(oxu, 0); -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
