> -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of Gupta, Ajay Kumar > Sent: Tuesday, December 15, 2009 8:45 PM > To: felipe.balbi@xxxxxxxxx > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx > Subject: RE: [PATCH 1/4] musb: get rid of unneeded musb->config->dyn_fifo > > > >Hi, > > > >On Tue, Dec 15, 2009 at 02:31:46PM +0100, ext Ajay Kumar Gupta wrote: > >>diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h > >>index d437556..c5f006e 100644 > >>--- a/include/linux/usb/musb.h > >>+++ b/include/linux/usb/musb.h > >>@@ -30,7 +30,6 @@ struct musb_hdrc_eps_bits { > >> struct musb_hdrc_config { > >> /* MUSB configuration-specific details */ > >> unsigned multipoint:1; /* multipoint device */ > >>- unsigned dyn_fifo:1; /* supports dynamic fifo sizing */ > >> unsigned soft_con:1; /* soft connect required */ > >> unsigned utm_16:1; /* utm data witdh is 16 bits */ > >> unsigned big_endian:1; /* true if CPU uses big-endian */ > > > >same problem as the other patch I sent: > > > >$ git grep -w dyn_fifo arch/ > >arch/arm/mach-davinci/usb.c: .dyn_fifo = true, > >arch/arm/mach-omap2/usb-musb.c: .dyn_fifo = 1, > >arch/blackfin/mach-bf527/boards/cm_bf527.c: .dyn_fifo = 0, > >arch/blackfin/mach-bf527/boards/ezbrd.c: .dyn_fifo = 0, > >arch/blackfin/mach-bf527/boards/ezkit.c: .dyn_fifo = 0, > >arch/blackfin/mach-bf548/boards/cm_bf548.c: .dyn_fifo = 0, > >arch/blackfin/mach-bf548/boards/ezkit.c: .dyn_fifo = 0, > > > >we have to agree who will carry the arch changes. > > >what we can do is mark that field as deprecated and give one major > >release for people to remove that from their boards, then we send a > >patch finally removing it. > > Even with one major release window someone has to submit patch removing > them > from arch/ files. So I think it's better to remove them now itself. we can > seperately > submit patches to respective maintainers. Or best is if Greg can accept > those changes > which are mostly trivial. Felipe, Any update on this ? Shall I send the series again with __deprecated ? or If you can just add it on your own? Thanks, Ajay > > -Ajay-- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
