On Mon, Apr 29, 2024 at 03:35:59PM +0200, Javier Carrasco wrote: > The first thing i2c_get_match_data() does is calling > device_get_match_data(), which already checks if there is a fwnode. > > Remove explicit usage of device_get_match_data() as it is already > included in i2c_get_match_data(). > > Signed-off-by: Javier Carrasco <javier.carrasco@xxxxxxxxxxxxxx> Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > --- > drivers/usb/typec/tipd/core.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c > index 191f86da283d..ad76dbd20e65 100644 > --- a/drivers/usb/typec/tipd/core.c > +++ b/drivers/usb/typec/tipd/core.c > @@ -1365,10 +1365,7 @@ static int tps6598x_probe(struct i2c_client *client) > TPS_REG_INT_PLUG_EVENT; > } > > - if (dev_fwnode(tps->dev)) > - tps->data = device_get_match_data(tps->dev); > - else > - tps->data = i2c_get_match_data(client); > + tps->data = i2c_get_match_data(client); > if (!tps->data) > return -EINVAL; > > > -- > 2.40.1 -- heikki
