On 4/20/2024 5:01 PM, Krzysztof Kozlowski wrote:
On 20/04/2024 06:48, Krishna Kurapati wrote:
Add the compatible string for SC8280 Multiport USB controller from
Qualcomm.
There are 4 power event interrupts supported by this controller
(one for each port of multiport controller). Add all the 4 as
non-optional interrupts for SC8280XP-MP
Also each port of multiport has one DP and one DM IRQ. Add all DP/DM
IRQs related to 4 ports of SC8280XP Teritiary controller.
Also added SuperSpeed PHY interrupt for both Superspeed ports.
Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx>
Reviewed-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>
v21 and suddenly you drop tags requiring everyone to re-review this. I
do not think this process is working. I will not re-review this.
This is a friendly reminder during the review process.
It looks like you received a tag and forgot to add it.
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
If a tag was not added on purpose, please state why and what changed.
Hi Krzysztof,
There was a commit text change to fix minor nits:
-> One minor spell check: /s/oen/one
-> minor nits like: /s/ss/SuperSpeed
So removed the tags and requested for a review.
"Updated commit text in patches 2/5/6."
Apologies, My intention was to just fix the spell check and minor nits.
.
The changes in v21 were in patches 1/2/4/7/9.
Patches 3 and 8 were left untouched.
Made minor nit fixes to commit text in patches 5 and 6 so that it
feels more accurate.
Regards,
Krishna,
