> -----Original Message----- > From: Felipe Balbi [mailto:felipe.balbi@xxxxxxxxx] > Sent: Tuesday, December 15, 2009 1:10 PM > To: Gupta, Ajay Kumar > Cc: Balbi Felipe (Nokia-D/Helsinki); linux-usb@xxxxxxxxxxxxxxx; linux- > omap@xxxxxxxxxxxxxxx; david-b@xxxxxxxxxxx > Subject: Re: [PATCH 1/3] musb: save dynfifo in musb struct > > Hi, > > On Tue, Dec 15, 2009 at 08:37:38AM +0100, ext Gupta, Ajay Kumar wrote: > >As per current logic, user has to set dyn_fifo if mentor core supports it > >and it has to be set to '0' if core doesn't support it. So what's the > need > >for musb->config->dyn_fifo at all. We can very well decide based on only > >CONFIGDATA register bits alone. > > > >I think we should just get rid of this unwanted user defined flag. I will > >post a patch on this along with next revision. > > aaa ok, now I get what you're saying. > > You're suggesting to drop musb->config->dyn_fifo and decide > ep_config_from_table() or ep_config_from_hw() based on CONFIGDATA. > > Ok, makes sense. But first remove that before saving dyn_fifo on musb > structure. Another point, BlackFin doesn't have CONFIGDATA register and it always Returns '0' from it's custom function musb_read_configdata(). As it returns '0' and also BlackFin doesn't support Dynamic FIFO so Should be fine. Any comment ? -Ajay > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
