Re: [PATCH 1/3] musb: save dynfifo in musb struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Dec 15, 2009 at 08:37:38AM +0100, ext Gupta, Ajay Kumar wrote:
As per current logic, user has to set dyn_fifo if mentor core supports it
and it has to be set to '0' if core doesn't support it. So what's the need
for musb->config->dyn_fifo at all. We can very well decide based on only
CONFIGDATA register bits alone.

I think we should just get rid of this unwanted user defined flag. I will
post a patch on this along with next revision.

aaa ok, now I get what you're saying.

You're suggesting to drop musb->config->dyn_fifo and decide ep_config_from_table() or ep_config_from_hw() based on CONFIGDATA.

Ok, makes sense. But first remove that before saving dyn_fifo on musb structure.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux